Re: [PATCH 5/7] xfs: introduce xfs_is_dax_state_changing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/7] xfs: introduce xfs_is_dax_state_changing
From: Christoph Hellwig <hch@xxxxxx>
Date: Tue, 26 Sep 2017 08:33:14 +0200
Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "Darrick J. Wong" <darrick.wong@xxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, Dave Chinner <david@xxxxxxxxxxxxx>, Jan Kara <jack@xxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxxxxxxx>, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-nvdimm@xxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <20170925231404.32723-6-ross.zwisler@linux.intel.com>
User-agent: Mutt/1.5.17 (2007-11-01)

> +static bool
> +xfs_is_dax_state_changing(
> +	unsigned int		xflags,
> +	struct xfs_inode	*ip)

And I have no fricking idea what 'is_dax_state_changing' is supposed
to mean for the caller.  This needs a better name and/or a comment
explaining the function.

References:
- [PATCH 0/7] re-enable XFS per-inode DAX
  - From: Ross Zwisler
- [PATCH 5/7] xfs: introduce xfs_is_dax_state_changing
  - From: Ross Zwisler

Prev by Date: Re: [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path
Next by Date: Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()
Previous by thread: [PATCH 5/7] xfs: introduce xfs_is_dax_state_changing
Next by thread: [PATCH 3/7] xfs: protect S_DAX transitions in XFS read path
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux