> + if (iov_iter_rw(iter) == WRITE && !is_sync_kiocb(iocb) && > + !inode->i_sb->s_dio_done_wq) { > + ret = sb_init_dio_done_wq(inode->i_sb); Wrong indentation for the continuation of the if conditional. Except for that the patch looks fine: Reviewed-by: Christoph Hellwig <hch@xxxxxx>