On 09/20/2017 08:17 AM, Jan Kara wrote: > On Tue 19-09-17 13:53:02, Jens Axboe wrote: >> This whole function is... interesting. Change the wakeup call >> to the flusher threads to pass in nr_pages == 0, instead of >> some random number of pages. This matches more closely what >> similar cases do for memory shortage/reclaim. >> >> Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> > > Ok, probably makes sense. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > BTW, after this nobody seems to use the number of pages for > wakeup_flusher_threads() so can you just delete the argument for the > function? After all system-wide wakeup is useful only for system wide > sync(2) or memory reclaim so number of pages isn't very useful... Great observation! That's true, and if we kill that, it enables further cleanups down the line for patch 5 and 6. I have incorporated that. -- Jens Axboe
