On Tue 19-09-17 13:53:05, Jens Axboe wrote: > We don't have any callers outside of fs-writeback.c anymore, > make it private. > > Signed-off-by: Jens Axboe <axboe@xxxxxxxxx> You can add: Reviewed-by: Jan Kara <jack@xxxxxxx> Honza > --- > fs/fs-writeback.c | 4 ++-- > include/linux/backing-dev.h | 2 -- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c > index 03fda0830bf8..7564347914f8 100644 > --- a/fs/fs-writeback.c > +++ b/fs/fs-writeback.c > @@ -933,8 +933,8 @@ static void bdi_split_work_to_wbs(struct backing_dev_info *bdi, > > #endif /* CONFIG_CGROUP_WRITEBACK */ > > -void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > - bool range_cyclic, enum wb_reason reason) > +static void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > + bool range_cyclic, enum wb_reason reason) > { > struct wb_writeback_work *work; > > diff --git a/include/linux/backing-dev.h b/include/linux/backing-dev.h > index 854e1bdd0b2a..157e950a70dc 100644 > --- a/include/linux/backing-dev.h > +++ b/include/linux/backing-dev.h > @@ -38,8 +38,6 @@ static inline struct backing_dev_info *bdi_alloc(gfp_t gfp_mask) > return bdi_alloc_node(gfp_mask, NUMA_NO_NODE); > } > > -void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, > - bool range_cyclic, enum wb_reason reason); > void wb_start_background_writeback(struct bdi_writeback *wb); > void wb_workfn(struct work_struct *work); > void wb_wakeup_delayed(struct bdi_writeback *wb); > -- > 2.7.4 > -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR