On 2017/9/12 9:53, Chao Yu wrote: > On 2017/9/11 11:38, Jaegeuk Kim wrote: >> If issue_cond is true, it does double count for # of issued commands. >> >> Signed-off-by: Jaegeuk Kim <jaegeuk@xxxxxxxxxx> > > Reviewed-by: Chao Yu <yuchao0@xxxxxxxxxx> As Daeho Jeong mentioned, the change makes 'iter > DISCARD_ISSUE_RATE' dead code, I just misread iter and issued variable, sorry. :( Thanks, > >> --- >> fs/f2fs/segment.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c >> index 7fd742f747ce..25196ff5d587 100644 >> --- a/fs/f2fs/segment.c >> +++ b/fs/f2fs/segment.c >> @@ -1087,7 +1087,7 @@ static int __issue_discard_cmd(struct f2fs_sb_info *sbi, bool issue_cond) >> issued++; >> __submit_discard_cmd(sbi, dc); >> } >> - if (issue_cond && iter++ > DISCARD_ISSUE_RATE) >> + if (issue_cond && iter > DISCARD_ISSUE_RATE) >> goto out; >> } >> if (list_empty(pend_list) && dcc->pend_list_tag[i] & P_TRIM) >> > > >
