On Tue, Sep 05, 2017 at 10:11:16PM +0300, Amir Goldstein wrote: > Cherry-picked the relevant common bits from commit 70d41e17164b > in Josef Bacik's fstests tree (https://github.com/josefbacik/fstests). > Quoting from Josef's commit message: > > This patch adds the supporting code for using the dm-log-writes > target. The dmlogwrites code is similar to the dmflakey code, it just > gives us functions to build and tear down a dm-log-writes target. We > add a new LOGWRITES_DEV variable to take in the device we will use as > the log and add checks for that. > > [Amir:] > - Removed unneeded _test_falloc_support > - Moved _require_log_writes to dmlogwrites > - Document _require_log_writes > - Address review comments by Eryu Guan > > Cc: Josef Bacik <jbacik@xxxxxx> > Signed-off-by: Amir Goldstein <amir73il@xxxxxxxxx> > --- ... > +# _replay_log <mark> One additional nit, this comment can be updated to reflect new name :) > +# > +# This replays the log contained on $LOGWRITES_DEV onto $SCRATCH_DEV upto the > +# mark passed in. > +_log_writes_replay_log() Thanks, Eryu