On Thu, Aug 24, 2017 at 01:26:24PM -0600, Ross Zwisler wrote: > On Thu, Aug 24, 2017 at 05:22:05PM +0200, Christoph Hellwig wrote: > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > This is obviously correct, but the lack of changelog makes it unclear why the > change is being made. Does a later patch in the series depend on > iomap_page_mkwrite() returning VM_FAULT_* codes? Is this just cleanup so you > can hide the block_page_mkwrite_return() call inside of iomap_page_mkwrite()? > > I think it's the former, so the logic in __xfs_filemap_fault() is simpler? Yes.
