On Wed 23-08-17 11:34:00, Christoph Hellwig wrote: > > @@ -1416,6 +1416,7 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > > * @vmf: The description of the fault > > * @pe_size: Size of the page to fault in > > * @ops: Iomap ops passed from the file system > > + * @pfnp: PFN to insert for synchronous faults if fsync is required > > * > > * When a page fault occurs, filesystems may call this helper in > > * their fault handler for DAX files. dax_iomap_fault() assumes the caller > > @@ -1423,13 +1424,13 @@ static int dax_iomap_pmd_fault(struct vm_fault *vmf, > > * successfully. > > */ > > int dax_iomap_fault(struct vm_fault *vmf, enum page_entry_size pe_size, > > - const struct iomap_ops *ops) > > + const struct iomap_ops *ops, pfn_t *pfnp) > > Please keep the iomap_ops argument the last one for the exported > function (and probably all others for consistency). Hum, I wanted the output argument to be the last one. But I don't care much. Swapped. > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks! Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
