On Wed 16-08-17 11:08:12, Andreas Dilger wrote: > On Aug 16, 2017, at 9:41 AM, Jan Kara <jack@xxxxxxx> wrote: > > > > Push down acquisition of dqio_sem into ->get_next_id() callback. Mostly > > for consistency with other operations. > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > I was initially thinking that this patch also needed to modify the > filesystem-specific code in a similar way, but ext4 and reiserfs > use dquot_get_next_id() internally, ocfs2 appears to have its own > locking, and XFS is doing completely its own thing. > > It is a bit confusing that there are both dquot_operation.get_next_id > as well as quota_format_ops.get_next_id methods that are similar but > not totally the same thing. It might make sense to rename the > quota_format_ops method like .get_next_id_format or similar to be able > to distinguish them? Yeah, they are two different levels of abstraction of the same operation. I agree that the fact that names are matching is a bit confusing. I'll think how to differentiate these names... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
