Re: [PATCH 07/27] quota: Remove locking for reading from the old quota format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 16, 2017, at 9:41 AM, Jan Kara <jack@xxxxxxx> wrote:
> 
> The old quota format has fixed offset in quota file based on ID so
> there's no locking needed against concurrent modifications of the file
> (locking against concurrent IO on the same dquot is still provided by
> dq_lock).
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Reviewed-by: Andreas Dilger <adilger@xxxxxxxxx>

> ---
> fs/quota/quota_v1.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/fs/quota/quota_v1.c b/fs/quota/quota_v1.c
> index d534c4043237..12d69cda57cc 100644
> --- a/fs/quota/quota_v1.c
> +++ b/fs/quota/quota_v1.c
> @@ -61,7 +61,6 @@ static int v1_read_dqblk(struct dquot *dquot)
> 	if (!dqopt->files[type])
> 		return -EINVAL;
> 
> -	down_read(&dqopt->dqio_sem);
> 	/* Set structure to 0s in case read fails/is after end of file */
> 	memset(&dqblk, 0, sizeof(struct v1_disk_dqblk));
> 	dquot->dq_sb->s_op->quota_read(dquot->dq_sb, type, (char *)&dqblk,
> @@ -75,7 +74,6 @@ static int v1_read_dqblk(struct dquot *dquot)
> 	    dquot->dq_dqb.dqb_isoftlimit == 0)
> 		set_bit(DQ_FAKE_B, &dquot->dq_flags);
> 	dqstats_inc(DQST_READS);
> -	up_read(&dqopt->dqio_sem);
> 
> 	return 0;
> }
> --
> 2.12.3
> 


Cheers, Andreas





Attachment: signature.asc
Description: Message signed with OpenPGP


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux