On Mon, Aug 14, 2017 at 03:07:19PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > When we introduced the bmap redo log items, we set MS_ACTIVE on the > mountpoint and XFS_IRECOVERY on the inode to prevent unlinked inodes > from being truncated prematurely during log recovery. This also had the > effect of putting linked inodes on the lru instead of evicting them. > > Unfortunately, we neglected to find all those unreferenced lru inodes > and evict them after finishing log recovery, which means that we leak > them if anything goes wrong in the rest of xfs_mountfs, because the lru > is only cleaned out on unmount. That's because if we fail xfs_mountfs() we haven't yet set up sb->s_root so generic_shutdown_super() won't call evict_inodes(), right? Is there anything else we might miss from the generic shutdown path that we need to do here? Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
