On Fri, Aug 11, 2017 at 02:25:19PM +1000, Dave Chinner wrote: > On Thu, Aug 10, 2017 at 09:11:59AM -0700, Matthew Wilcox wrote: > > On Thu, Aug 10, 2017 at 02:28:49PM +1000, Dave Chinner wrote: > > > If we scale this up to a container host which is using reflink trees > > > it's shared root images, there might be hundreds of copies of the > > > same data held in cache (i.e. one page per container). Given that > > > the filesystem knows that the underlying data extent is shared when > > > we go to read it, it's relatively easy to add mechanisms to the > > > filesystem to return the same page for all attempts to read the > > > from a shared extent from all inodes that share it. > > > > I agree the problem exists. Should we try to fix this problem, or > > should we steer people towards solutions which don't have this problem? > > The solutions I've been seeing use COW block devices instead of COW > > filesystems, and DAX to share the common pages between the host and > > each guest. > > That's one possible solution for people using hardware > virutalisation, but not everyone is doing that. It also relies on > block devices, which rules out a whole bunch of interesting stuff we > can do with filesystems... Assuming there's something fun we can do with filesystems that's interesting to this type of user, what do you think to this: Create a block device (maybe it's a loop device, maybe it's dm-raid0) which supports DAX and uses the page cache to cache the physical pages of the block device it's fronting. Use XFS+reflink+DAX on top of this loop device. Now there's only one copy of each page in RAM. We'd need to be able to shoot down all mapped pages when evicting pages from the loop device's page cache, but we have the right data structures in place for that; we just need to use them.
