On Thu, Aug 10, 2017 at 07:01:33PM +1000, Dave Chinner wrote: > On Thu, Aug 10, 2017 at 08:57:37AM +0300, Kirill A. Shutemov wrote: > > On Thu, Aug 10, 2017 at 02:28:49PM +1000, Dave Chinner wrote: > > > Hi folks, > > > > > > I've recently been looking into what is involved in sharing page > > > cache pages for shared extents in a filesystem. That is, create a > > > file, reflink it so there's two files but only one copy of the data > > > on disk, then read both files. Right now, we get two copies of the > > > data in the page cache - one in each inode mapping tree. > > > > > > If we scale this up to a container host which is using reflink trees > > > it's shared root images, there might be hundreds of copies of the > > > same data held in cache (i.e. one page per container). Given that > > > the filesystem knows that the underlying data extent is shared when > > > we go to read it, it's relatively easy to add mechanisms to the > > > filesystem to return the same page for all attempts to read the > > > from a shared extent from all inodes that share it. > > > > > > However, the problem I'm getting stuck on is that the page cache > > > itself can't handle inserting a single page into multiple page cache > > > mapping trees. i.e. The page has a single pointer to the mapping > > > address space, and the mapping has a single pointer back to the > > > owner inode. As such, a cached page has a 1:1 mapping to it's host > > > inode and this structure seems to be assumed rather widely through > > > the code. > > > > I think to solve the problem with page->mapping we need something similar > > to what we have for anon rmap[1]. In this case we would be able to keep > > the same page in page cache for multiple inodes. > > Being unfamiliar with the anon rmap code, I'm struggling to see the > need for that much complexity here. The AVC abstraction solves a > scalability problem that, to me, doesn't exist for tracking multiple > mapping tree pointers for a page. i.e. I don't see where a list > traversal is necessary in the shared page -> mapping tree resolution > for page cache sharing. [ Cc: Rik ] The reflink interface has potential to construct a tree of dependencies between reflinked files similar in complexity to tree of forks (and CoWed anon mappings) that lead to current anon rmap design. But it's harder to get there accidentally. :) > I've been thinking of something simpler along the lines of a dynamic > struct page objects w/ special page flags as an object that allows > us to keep different mapping tree entries for the same physical > page. Seems like this would work for read-only sharing, but perhaps > I'm just blind and I'm missing something I shouldn't be? Naive approach would be just to put all connected through reflink mappings on the same linked list. page->mapping can point to any of them in this case. To check that the page actually belong to the mapping we would need to look into radix-tree. Something like this we had before current anon rmap design, but with checking page tables instead of radix-tree as primary reference. > > The long term benefit for this is that we might be able to unify a lot of > > code for anon and file code paths in mm, making anon memory a special case > > of file mapping. > > > > The downside is that anon rmap is rather complicated. I have to re-read > > the article everytime I deal with anon rmap to remind myself how it works. > > Yeah, that's a problem - if you have trouble with it, I've got no > hope.... :/ -- Kirill A. Shutemov
