Re: [PATCH v3 01/49] block: drbd: comment on direct access bvec table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ming Lei <ming.lei@xxxxxxxxxx>
Subject: Re: [PATCH v3 01/49] block: drbd: comment on direct access bvec table
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Aug 2017 04:12:53 -0700
Cc: Jens Axboe <axboe@xxxxxx>, Christoph Hellwig <hch@xxxxxxxxxxxxx>, Huang Ying <ying.huang@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx
In-reply-to: <20170808084548.18963-2-ming.lei@redhat.com>
User-agent: Mutt/1.8.3 (2017-05-23)

I really don't think that these comments are all that useful.
A big comment near the bi_io_vec field defintion explaining the rules
for access would be a lot better.

References:
- [PATCH v3 00/49] block: support multipage bvec
  - From: Ming Lei
- [PATCH v3 01/49] block: drbd: comment on direct access bvec table
  - From: Ming Lei

Prev by Date: Re: [PATCH RFC v2] Add /proc/pid/smaps_rollup
Next by Date: Re: [PATCH v3 04/49] mm: page_io.c: comment on direct access to bvec table
Previous by thread: [PATCH v3 01/49] block: drbd: comment on direct access bvec table
Next by thread: [PATCH v3 14/49] block: bounce: avoid direct access to bvec table
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]

Powered by Linux