On Thu, Jul 27, 2017 at 03:12:41PM +0200, Jan Kara wrote: > dax_insert_mapping() has lots of arguments and a lot of them is actuall > duplicated by passing vm_fault structure as well. Change the function to > take the same arguments as dax_pmd_insert_mapping(). Some of this is probably for historic reasons, when I did the initial pass at iomap based DAX dax_insert_mapping still had to be usable for the non-DAX case. Either way this looks like a great cleanup: Reviewed-by: Christoph Hellwig <hch@xxxxxx>