On Tue, Jul 18, 2017 at 06:16:31PM +0200, Jan Kara wrote: > On Thu 22-06-17 15:31:05, Jan Kara wrote: > > When new directory 'DIR1' is created in a directory 'DIR0' with SGID bit > > set, DIR1 is expected to have SGID bit set (and owning group equal to > > the owning group of 'DIR0'). However when 'DIR0' also has some default > > ACLs that 'DIR1' inherits, setting these ACLs will result in SGID bit on > > 'DIR1' to get cleared if user is not member of the owning group. > > > > Fix the problem by moving posix_acl_update_mode() out of > > __ext4_set_acl() into ext4_set_acl(). That way the function will not be > > called when inheriting ACLs which is what we want as it prevents SGID > > bit clearing and the mode has been properly set by posix_acl_create() > > anyway. > > > > Fixes: 073931017b49d9458aa351605b43a7e34598caef > > CC: stable@xxxxxxxxxxxxxxx > > CC: linux-ext4@xxxxxxxxxxxxxxx > > CC: "Theodore Ts'o" <tytso@xxxxxxx> > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > Ted, can you please pick up this fix? Thanks! Thanks, applied. - Ted
