This is a relatively minor detail in the rather bigger context of this patch, but... > @@ -642,6 +644,7 @@ struct inode { > struct list_head inotify_watches; /* watches on this inode */ > struct mutex inotify_mutex; /* protects the watches list */ > #endif > + wait_queue_head_t i_revoke_wait; That seems like a relatively hefty addition to every inode in the system when revoke - I think - will be a fairly rare operation. Would there be any significant cost to using a single, global revoke-wait queue instead of growing the inode structure? jon - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html