On Sat, Jun 24, 2017 at 11:45:01AM -0700, Deepa Dinamani wrote: > The series aims at isolating data conversions of time_t based structures: > struct timespec and struct itimerspec at user space boundaries. > This helps to later change the underlying types to handle y2038 changes > to these. Nice... A few questions: * what about setitimer(2)? Right now that's the only remaining user of get_compat_itimerval(); similar for getitimer(2) and put_compat_itimerval(). * you have two callers of get_compat_itimerspec64(); one is followed by itimerspec64_valid(), another - by its open-coded analogue. The same goes for get_itimerspec64(); wouldn't it be better to have both check the validity immediately and simply fail with -EINVAL? Matter of taste, but... * should __sys_recvmmsg() switch to timespec64?
