On Thu, Jun 15, 2017 at 10:59:56AM -0500, Goldwyn Rodrigues wrote: > static inline int kiocb_set_rw_flags(struct kiocb *ki, int flags) > { > - if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC))) > + if (unlikely(flags & ~(RWF_HIPRI | RWF_DSYNC | RWF_SYNC | RWF_NOWAIT))) Minor nit: that calls for something like if (unlikely(flags & ~RWF_ALL) > return -EOPNOTSUPP; with corresponding definition.