On Wed, Jun 07, 2017 at 01:25:51PM +0100, Alan Cox wrote: > > What's wrong with saying that the only way to interrupt firmware > > loading is to kill the process? So ctrl-c will no longer interrupt > > it, but I do not think that ease of aborting firmware update is > > primary goal here. I consider simple is good here. > > Agreed 100%. The user process did not ask for firmware load, it asked > for an I/O operation. Semantically it should appear as if someone else > did the firmware load and it just had to wait for it to happen. Fine by me ! Will wrap up the patch for the new killable swait then. I suppose noting it as a stable fix is worth it given the known issues with for example Android killing loaders unexpectedly. Unless I hear otherwise I'll also provide a follow up to return -EINTR instead of -EAGAIN if swait returned -ERESTARTSYS, this way at least userspace could tell a signal was definitely received. I *don't* think that follow up is required for stable though. Luis
