Re: [PATCH 07/10] fs: return on congested block device

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/04/2017 11:35 PM, Goldwyn Rodrigues wrote:
> @@ -1900,6 +1905,17 @@ generic_make_request_checks(struct bio *bio)
>  		goto end_io;
>  	}
>  
> +	/*
> +	 * For a REQ_NOWAIT based request, return -EOPNOTSUPP
> +	 * if queue does not have QUEUE_FLAG_NOWAIT_SUPPORT set
> +	 * and if it is not a request based queue.
> +	 */
> +
> +	if ((bio->bi_opf & REQ_NOWAIT) && !queue_is_rq_based(q)) {
> +		err = -EOPNOTSUPP;
> +		goto end_io;
> +	}

There is no QUEUE_FLAG_NOWAIT, this looks like a somewhat stale comment.

This patch should be prefixed with 'block', not 'fs'.

-- 
Jens Axboe




[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux