Re: [PATCH v2 27/28] ext4: xattr inode deduplication

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Hmm... normally we'd supply sbi->s_csum_seed as the second argument so
> that the metadata checksum value also has the fs uuid stamped into it.

I have thought about using sbi->s_csum_seed and was a little hesitant
because it involves adding more complexity to e2fsprogs to handle
cases like changing uuid or turning off metadata_csum. After thinking
more about this, I think it is doable.

> Even if you dismiss that, we usually follow the convention of
> initializing the crc32c calculation with (~0U), not (0U), to strengthen
> crc32c's ability to detect zeroes being injected at the start of the
> stream.

Agreed, using ~0 is definitely better than 0.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux