On Wed, May 31, 2017 at 10:56 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > On Tue, May 30, 2017 at 11:35 PM, Vivek Goyal <vgoyal@xxxxxxxxxx> wrote: >> On Sun, May 28, 2017 at 05:43:45PM +0300, Amir Goldstein wrote: > ... >>> >>> Vivek, >>> >>> I added support for running my maser branch with old kernels >>> or with REDIRECT_DIR=n. >>> >>> User needs to request backward compat mode explicitly. >>> When using new command line arg --xdev, >>> dir rename tests that would return EXDEV are skipped. >>> > ... >> >> So --xdev will skip tests which are not supposed to pass without >> REDIRECT_DIR=n? > > Short answer - yes. > > Long answer: > Technically, those tests (rename-empty-dir, rename-pop-dir, rename-move-dir) > pass on David's master branch by expecting and getting EXDEV. > My master branch, OTOH, does not verify getting EXDEV with the --xdev > flag, so it will not uncover a hypothetical regression with REDIRECT_DIR=n > where those tests no longer return EXDEV. > Pushed to master: 680b310 Add a test to verify EXDEV behavior when OVERLAYFS_REDIRECT_DIR=n > >> >> Would be great if we could automate this. That is test which are not valid >> with current kernel/overlay configuration are skipped automatically. It >> totally up to you. :-) >> > > Yes, that would be great. > Need to test "`cat /sys/module/overlay/parameters/redirect_dir`" = Y > But need to take care to modprobe overlay before the test. > Pushed to master: 7a8bd82 Check if redirect_dir is disabled and skip directory rename tests Cheers, Amir.
