On Wed, May 31, 2017 at 3:05 PM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: > Are you suggesting to move the inuse lock to the workdir inode? doable. > I guess I choose to lock workdir/work because of the may_delete > protection it provides, > but you questioned that part anyway. Yes, I think we should protect workdir/upperdir with I_INUSE. > I don't mind dropping the "?" though - perhaps phrase the error more > generically: > pr_err("overlayfs: workdir is in-use by another mount\n"); Okay. Thanks, Miklos