> On 28 May 2017 at 11:34 Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > On Sun, May 21, 2017 at 05:39:47PM +0200, Fabian Frederick wrote: > > This small patchset reorganizes magic.h and fixes filesystems > > which defined locally super magic values. > > And what's the point? Current magic.h organization is strange for the less. Filesystems generally use SUPER_MAGIC values from magic.h instead of a local definition plus it looks easier for new subsystems to look at just one file when seeking for unique value.