> +struct config_item *config_item_get_unless_zero(struct config_item *item) > +{ > + return item && kref_get_unless_zero(&item->ci_kref) ? item : NULL; > +} > +EXPORT_SYMBOL(config_item_get_unless_zero); Style nipick, I'd prefer something like: if (item && !kref_get_unless_zero(&item->ci_kref)) item = NULL; return item; Otherwise this looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx> or should I pick it up through the configfs tree?