On Thu, Nov 29, 2007 at 01:46:04PM -0500, Oleg Drokin wrote: > Hello! > > Per our discussion, I am resending this patch that fixes a leak in > nlmsvc_testlock. It is addition to another leak fixing patch you > already have. Without the patch, there is a leakage of nlmblock > structure refcount that holds a reference nlmfile structure, that > holds a reference to struct file, when async GETFL is used > (-EINPROGRESS return from file_ops->lock()), and also in some error > cases. Thanks for the fix! Looks right to me. Yes, somehow I missed this one when you sent it privately. Applied and pushed out to git://linux-nfs.org/~bfields/linux.git nfs-server-stable and I'll submit it for 2.6.25. Minor nit: your editor is messing up the whitespace; keep the indents all tabs. Also, for future patches, could you see Documentation/SubmittingPatches? In particular, see "12) Sign your work". And it'd be better to inline the patch if at all possible. Thanks again. --b. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
