Re: [patch 16/19] Use page_cache_xxx in fs/ext4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 28, 2007 at 07:58:45PM -0800, Christoph Lameter wrote:
> On Thu, 29 Nov 2007, David Chinner wrote:
> 
> > These three should use the pagesize variable.
> 
> ext4: use pagesize variable instead of the inline function
> 
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
> 
> ---
>  fs/ext4/inode.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> Index: mm/fs/ext4/inode.c
> ===================================================================
> --- mm.orig/fs/ext4/inode.c	2007-11-28 19:56:18.234382799 -0800
> +++ mm/fs/ext4/inode.c	2007-11-28 19:57:10.774132672 -0800
> @@ -1693,17 +1693,16 @@ static int ext4_journalled_writepage(str
>  		 * doesn't seem much point in redirtying the page here.
>  		 */
>  		ClearPageChecked(page);
> -		ret = block_prepare_write(page, 0, page_cache_size(mapping),
> -					ext4_get_block);
> +		ret = block_prepare_write(page, 0, pagesize, ext4_get_block);
>  		if (ret != 0) {
>  			ext4_journal_stop(handle);
>  			goto out_unlock;
>  		}
>  		ret = walk_page_buffers(handle, page_buffers(page), 0,
> -			page_cache_size(mapping), NULL, do_journal_get_write_access);
> +			pagesize, NULL, do_journal_get_write_access);
>  
>  		err = walk_page_buffers(handle, page_buffers(page), 0,
> -			page_cache_size(mapping), NULL, write_end_fn);
> +			pagesize, NULL, write_end_fn);
>  		if (ret == 0)
>  			ret = err;
>  		EXT4_I(inode)->i_state |= EXT4_STATE_JDATA;

ok.

Cheers,

dave.
-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux