Re: [patch 13/19] Use page_cache_xxx in fs/splice.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 28, 2007 at 07:50:16PM -0800, Christoph Lameter wrote:
> On Thu, 29 Nov 2007, David Chinner wrote:
> 
> > On Wed, Nov 28, 2007 at 05:11:05PM -0800, Christoph Lameter wrote:
> > > @@ -453,7 +454,7 @@ fill_it:
> > >  	 */
> > >  	while (page_nr < nr_pages)
> > >  		page_cache_release(pages[page_nr++]);
> > > -	in->f_ra.prev_pos = (loff_t)index << PAGE_CACHE_SHIFT;
> > > +	in->f_ra.prev_pos = page_cache_index(mapping, index);
> > 
> > 	in->f_ra.prev_pos = page_cache_pos(mapping, index, 0);
> > 
> 
> splice.c: Wrong inline function used
> 
> Signed-off-by: Christoph Lameter <clameter@xxxxxxx>
> 
> ---
>  fs/splice.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: mm/fs/splice.c
> ===================================================================
> --- mm.orig/fs/splice.c	2007-11-28 19:48:43.246633219 -0800
> +++ mm/fs/splice.c	2007-11-28 19:49:06.405882592 -0800
> @@ -454,7 +454,7 @@ fill_it:
>  	 */
>  	while (page_nr < nr_pages)
>  		page_cache_release(pages[page_nr++]);
> -	in->f_ra.prev_pos = page_cache_index(mapping, index);
> +	in->f_ra.prev_pos = page_cache_pos(mapping, index, 0);
>  
>  	if (spd.nr_pages)
>  		return splice_to_pipe(pipe, &spd);

Ok.

Cheers,

Dave.

-- 
Dave Chinner
Principal Engineer
SGI Australian Software Group
-
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux