On Wed, May 10, 2017 at 10:08:25PM +0300, Amir Goldstein wrote: > On Wed, May 10, 2017 at 9:02 PM, Christoph Hellwig <hch@xxxxxx> wrote: > > For some file systems we still memcpy into it, but in various places this > > already allows us to use the proper uuid helpers. More to come.. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > --- > > Series looks good! > > My main concern is that filesystems with char uuid[16] are here to stay, > or maybe, will be converted slowly. I'll take a stab to convert them ASAP, and add s_uuid support for you to more file systems once this initial series is done. > > Considering this, perhaps we should have a helper/macro to copy from > char[16] to *uuid_t and maybe BUILD_BUG_ON the size comparison? > #define bytes_to_uuid(dst, src) ... If the mix of proper types and u8 arrays was to stay that'd be the way to go, but I'd rather fix things up in a merge window or two instead of leaving us in a transitionary state forever.
