On Wed, 2017-05-10 at 14:01 +0200, Christoph Hellwig wrote: > On Wed, May 10, 2017 at 11:39:27AM +0300, Amir Goldstein wrote: > > To avoid stepping over each other toes, I propose the following work > > sequence: > > I agree on the list, but I've started a tree that has a slightly > different > sequence: > > (1) renamed uuid_be to uuid_t and uuid_le to guid_t, but keep the old > name for compat for now. > Including these items from your list: > > - Create helper variants uuid_cmp()/uuid_gen()/uuid_to_bin() > > (2): kill uuid_v1 by adding a union to uuid_t that has the v1 meaning > (and maybe more in the future) > > (3) > This patch set by Christoph: > > - re-define xfs's uuid_t as uuid_be (this patch) > > - more xfs uuid cleanups > > > (4): > V3 of 'hoist xfs uuid helpers' by me: > > - hoist uuid_t typedef to uuid.h > > - hoist helpers uuid_equal()/uuid_copy() to uuid.h > > - create helper uuid_is_null() > > - convert xfs to use the new uuid_is_null() > > (but now moved over the to plain uuid_t type) > > (5) > Promote uuid_t to VFS and filesystems (I can do it): > > - Convert sb->s_uuid to uuid_t > > - Convert some sample fs (tmpfs, ext2, ext4, ..) to uuid_t > > - Use uuid_copy() and uuid_gen() where due > > And the rest for latter > > > Kill off uuid_be (I can do it): > > - Convery uuid_be users to uuid_t and uuid_ helpers > > - Kill off uuid_be and uuid_be_ helpers > > > > Kill off generate_random_uuid (Christoph?): > > - Not sure what you're intentions are wrt to all users that use > > this helper to initialize a char[16] var? > > They really should be converted to either uuid_t or guid_t, or > just use prandom_bytes if they really aren't either a UUID or GUID > > > Maybe repeat the uuid_be->uuid_t process with uuid_le->guid_t > > (Andy?): > > - I don't think any of the above interferes with your work to > > convert > > ACPI to uuid_le? > > - You can actually start this work in parallel to uuid_be->uuid_t, > > because > > it will create trivial merge conflicts that we can easily sort out > > on the common > > development branch > > With my work I'm right now at item (5) of my list, I'll send it out > later this afternoon. I'm fine with above and it looks like I could rebase my current work whenever (1) has been done. Looking forward to repository with changes I can rebase on top of. -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy
