On Wed, 2017-05-03 at 21:34 +0300, Amir Goldstein wrote:
> On Wed, May 3, 2017 at 8:15 PM, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> >
> > By the way, notice that uuid_v1 type (which had been moved to uuid.h
> > already) is the same what xfs uses as uuid_t.
> >
> > So, helpers against it we can prefix with uuid_v1_[foo_bar()].
> >
>
> I really don't see why we can't use the exact same helpers
> found in fs/xfs/uuid.c and uuid_t as well for that matter.
Does it make sense to have two types that defines the same?
> They are mostly similar to the libuuid API that filesystems
> tools use in userspace and they don't collide with your
> uuid_{le|be} helpers.
Okay, if you are insisting just move them to the header, we may simplify
it later, though I think that there is no makes sense to do any effort
that will be neglected in the future (so, just movement is fine, but
using it elsewhere I prefer to have 1 type and const for parameters).
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
