On Sun, Apr 30, 2017 at 3:54 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > On Sun, Apr 30, 2017 at 09:01:59AM +1000, Dave Chinner wrote: > >> Doesn't this make the struct export_opierations .get_uuid method >> somewhat redundant? Shouldn't that now be replaced with generic >> functions that looks at SB_I_HAVE_UUID before allowing PNFS export >> is allowed and then just use s_uuid directly in the PNFS code? > > Do we even need a flag? Checking if 16 bytes are not all zeroes isn't hard, > after all... Nope, it's not hard and that is what we do now. I posted the flag per Christoph's suggestion to see what others have to say. Amir.