On Thu, Apr 27, 2017 at 5:00 PM, David Howells <dhowells@xxxxxxxxxx> wrote: > Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > >> but s_uuid in the vfs superblock isn't a pointer: >> >> u8 s_uuid[16]; /* UUID */ >> >> (or am I missing your point?) > > No, I'm getting it wrong. For some reason I'm thinking it's a pointer. I > should probably know better. I wonder if it should be a struct uuid_v1... > If anything, I think we should hoist uuid_t from fs/xfs/uuid.h. Or arbitrarily use uuid_le, just so it is easy to do uuid_le_cmp(sb->s_uuid, NULL_UUID_LE)