On Thu, Apr 27, 2017 at 10:59 AM, Christoph Hellwig <hch@xxxxxx> wrote: > On Thu, Apr 27, 2017 at 10:58:31AM +0300, Amir Goldstein wrote: >> Unless mounted with nouuid, copy the uuid of the filesystem to >> struct super block s_uuid field, as several other filesystems do. > > This looks okay ... ish. > > Until we have a flag in the superblock that a given fs fills out s_uuid > no one can rely on it. So please add the infrastructure that consumers > can actually make use of it while you're at it. All right. makes sense. will do.