On Wed, Apr 19, 2017 at 6:16 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > On Mon, Apr 17, 2017 at 1:59 AM, Amir Goldstein <amir73il@xxxxxxxxx> wrote: >> When mounted with mount option redirect_dir=fh, >> every copy up of lower directory stores the lower >> dir file handle in overlay.fh xattr of upper dir. > > Is there a disadvantage to doing this unconditionally? (Same goes for patch 4) > > Is there a disadvantage to doing this even for the non-samefs case? > Not that I can think of. It's just that all the features that stable inode brings to the table only work for same_fs right now, but we can store overlay.fh anyway. When you get a chance please let me know your preference wrt configuration options. I don't see a reason to let the user turn off storing overlay.fh? Is there a reason to let user turn off lookup by fh? for files? (i.e. to preserve old weird behavior?) Amir.
