On Tue, Apr 18, 2017 at 05:05:12PM +0300, Amir Goldstein wrote: [..] > > (This ovl_lookup() logic has become really twisted now. I wished it was > > little easier to read.) > > > > Me too. IMO, most of the complexity is in the fallbacks from redirect > by fh to full path to relative path. Eliminating some of these fallbacks > and maybe having separate lookup op per mode, may simplify the code. In general, why are we falling back to path based lookup. If lower dirs were copied or something else, that's a configuration error and overlayfs will have undefined behavior? Vivek