On Wed 12-04-17 01:14:06, Christoph Hellwig wrote: > > + sb->s_bdi = bdi_get(mtd_bdi); > > + sb->s_iflags |= SB_I_DYNBDI; > > FTI, while I think this is a faithful conversion of the existing code, > the single bdi for all MTD devices looks rather bogus to me.. Yeah, I don't understand why they don't allocate backing_dev_info per superblock as other places do but I didn't dare to change that since there are user visible consequences of that. I suspect they don't really want anything from the bdi and allocate it only so that other parts of the kernel are happy. > Otherwise this looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> Thanks. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR