On Thu 16-03-17 17:52:46, Amir Goldstein wrote: > >> This chunk has become overly convoluted IMO. > >> How about something like this: > >> > >> conn = fsnotify_connector_get(connp, lock); > >> > >> spin_lock(&mark->lock); > >> spin_lock(lock); > >> > >> Where fsnotify_connector_get() acquires and releases only the object lock > >> and only for the case of allocating a new connector. > > > > Agreed and changed. > > > > Looks very neat now. > You may add > Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx> > > (based on commit 6e23640 on your testing branch) > > I believe that addresses the last of my review comments. > Let me know if I missed any Rvb tag. Thanks for review! All patches have your tag now. Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR
