Re: [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jeff Layton <jlayton@xxxxxxxxxx>
Subject: Re: [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty
From: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>
Date: Thu, 9 Mar 2017 17:06:48 -0700
Cc: viro@xxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, konishi.ryusuke@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, ross.zwisler@xxxxxxxxxxxxxxx, jack@xxxxxxx, neilb@xxxxxxxx, openosd@xxxxxxxxx, adilger@xxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx
In-reply-to: <20170308162934.21989-2-jlayton@redhat.com>
Mail-followup-to: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>, Jeff Layton <jlayton@xxxxxxxxxx>, viro@xxxxxxxxxxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, konishi.ryusuke@xxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, jack@xxxxxxx, neilb@xxxxxxxx, openosd@xxxxxxxxx, adilger@xxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.7.1 (2016-10-04)

On Wed, Mar 08, 2017 at 11:29:26AM -0500, Jeff Layton wrote:
> The error code should be negative. Since this ends up in the default
> case anyway, this is harmless, but it's less confusing to negate it.
> 
> Signed-off-by: Jeff Layton <jlayton@xxxxxxxxxx>

Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>

References:
- [PATCH v2 0/9] mm/fs: get PG_error out of the writeback reporting business
  - From: Jeff Layton
- [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty
  - From: Jeff Layton

Prev by Date: Re: [PATCH] block, writeback: wait for writeback to finish before detaching wb
Next by Date: Re: [PATCH v2 2/9] mm: drop "wait" parameter from write_one_page
Previous by thread: [PATCH v2 1/9] mm: fix mapping_set_error call in me_pagecache_dirty
Next by thread: [PATCH v2 2/9] mm: drop "wait" parameter from write_one_page
Index(es):
- Date
- Thread

[Index of Archives] [Linux Ext4 Filesystem] [Union Filesystem] [Filesystem Testing] [Ceph Users] [Ecryptfs] [AutoFS] [Kernel Newbies] [Share Photos] [Security] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux Cachefs] [Reiser Filesystem] [Linux RAID] [Samba] [Device Mapper] [CEPH Development]