Re: [RFC][PATCH 02/10] fs: Avoid looking at i_count without i_lock held

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 24, 2017 at 08:56:06AM -0800, Linus Torvalds wrote:
> This one looks very questionable.
> 
> Taking the lock for every single inode, even when we can tell that it's
> pointless, is horrid.
> 
> Even if you really think you found a race, i think it would be better to
> leave the unlocked read around as an optimistic check, and then do a safe
> double check read inside the lock (together with the i_state checks)
> 
> Hmm?

Yeah, pretty dumb that.



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux