On 02/08/2017 01:59 AM, Christoph Hellwig wrote: > On Tue, Feb 07, 2017 at 08:33:23PM -0600, Goldwyn Rodrigues wrote: >> From: Goldwyn Rodrigues <rgoldwyn@xxxxxxxx> >> >> aio_flags are not checked when performing io_submit() and >> can contain non-conforming values. >> Return -EINVAL if they are invalid. > > while this is what we should have done from the start it could break > existing userspace programs now. > Yes, I agree. it would be the one's who are using it incorrectly and have been certified to work. However, I did run it through LTP and it passed the tests (I understand it does not represent all of userspace programs). We would need to correct behavior at some point in time hoping not many depend on it. Besides, this would also restrict expansion of aio_flags, which I intend to do... (yeah, you see my ulterior motive now ;)) -- Goldwyn
