Re: [PATCH] orangefs: Dan Carpenter influenced cleanups...

[Dan Carpenter <dan.carpenter@xxxxxxxxxx>]

On Mon, Feb 06, 2017 at 11:21:20AM -0500, Mike Marshall wrote:
> @@ -996,7 +996,7 @@ int orangefs_debugfs_new_client_string(void __user *arg)
>  		if (orangefs_prepare_debugfs_help_string(0)) {
>  			gossip_err("%s: no debug help string \n",
>  				   __func__);
> -			return -EIO;
> +			return -EFAULT;
>  		}

The rest looks nice but -EFAULT isn't right here.  It should propogate
the return from orangefs_prepare_debugfs_help_string().

		ret = orangefs_prepare_debugfs_help_string(0);
		if (ret) {
			gossip_err("%s: no debug help string \n",
				   __func__);
			return ret;
		}

regards,
dan carpenter