On Wed 01-02-17 15:22:12, Amir Goldstein wrote:
> > + conn = mark->connector;
> > + spin_lock(&conn->lock);
> > + hlist_del_init_rcu(&mark->obj_list);
> > + if (hlist_empty(&conn->list)) {
> > + if (conn->flags & FSNOTIFY_OBJ_TYPE_INODE)
> > + inode = conn->inode;
> > + } else
> > + __fsnotify_recalc_mask(conn);
>
> I was told that "if {} else ;" is a coding practice that asks for
> trouble and I tend to agree,
> so please add {} to else case.
Right. Fixed. Thanks for review.
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR
