On Wed, Feb 01, 2017 at 01:21:40AM -0800, Dan Williams wrote: > > In/Out parameters are always a bit problematic in terms of API clarity. > > And updating a device-relative address with an absolute physical one > > sounds like an odd API for sure. > > Yes, it does, and I thought better of it shortly after sending that. How about: > > long dax_direct_access(struct dax_device *dax_dev, pgoff_t pgoff, > unsigned long nr_pages, void **kaddr, pfn_t *pfn) Yes, that looks good to me.
