On Sun, Jan 22, 2017 at 05:54:19PM +0100, Christoph Hellwig wrote: > I've got a report that there NFS clients that send SETATTR requests that > mix size changes with uid/gid changes That sounds a little weird. Do you know anything about which clients, or how common the behavior is? > (see the recent pynfs patch for an > artifical reproducer). At least XFS and GFS2 are very unhappy with this, > and other file systems also don't seem to handle the case correctly. Does this cause a crash or corruption, or "just" fail to set the attributes correctly? (Just wondering how urgent the fix is....). --b. > > This patch splits the truncate processing in NFS out into a separate > ->setattr call and uses the vfs_truncate helper for it, which also happens > to shrink the NFSD code size by reusing more VFS boiler plate code. > > I suspect in the mid-term we really should add a ->truncate method (different > from the previous callback of the same name) to separate the two concepts > clearly at the VFS level. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
