Hi, On Thu 19-01-17 14:13:26, Amir Goldstein wrote: > I implemented freeze/thaw of overlayfs, because I need it for > overlay snapshots (CoW decision is made before mnt_wat_write(upper) > and I need to serialize it with snapshot take). > > Not sure if there are other use cases for overlayfs freeze?? > > Tested freeze stress with xfstest generic/068 generic/390. > > While staring at the code, I realized that syncfs(2) for overlayfs > seems broken. It looks like only inodes are synced and upper fs > metadata is not being flushed, but I could be wrong. > > Tested sync sanity with -g quick (although no test calls syncfs directly). > Tested the usual unionmount sanity over xfs and over tmpfs. > > I am not sure exactly how to write a test case to verify this alleged > breakage? > > Jan, > > Can you please have a look? So I don't really understand overlayfs but from my 10000 feet view your changes make sense to me... Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
