On Sun, Oct 28, 2007 at 07:57:47PM -0700, Daniel Phillips wrote: > On 10/28/07, Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > While you're at it, it's probably worth splitting this out into > > a small helper function. > > Why? Is the same pattern called from more than one place? Becauase it's a lot more readable. ioctl subcommands are invidividual functionality, and separating them out into small self-contained functions makes the code a lot more readable. - To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
