On Sun 08-01-17 14:35:51, Amir Goldstein wrote: > On Fri, Jan 6, 2017 at 12:44 PM, Jan Kara <jack@xxxxxxx> wrote: > > Currently we initialize mark->group only in fsnotify_add_mark_lock(). > > However we will need to access fsnotify_ops of corresponding group from > > fsnotify_put_mark() so we need mark->group initialized earlier. Do that > > in fsnotify_init_mark() which has a consequence that once > > fsnotify_init_mark() is called on a mark, the mark has to be destroyed > > by fsnotify_put_mark(). > > > > Signed-off-by: Jan Kara <jack@xxxxxxx> > > The API change looks good to me, but as I wrote on v1, > I rather that Paul reviews the changes in the audit code, > which is the code that was missing the fsnotify_put_mark() > calls. OK. Paul? Honza -- Jan Kara <jack@xxxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
