Re: [PATCH 08/22] fsnotify: Move queueing of mark for destruction into fsnotify_put_mark()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 6, 2017 at 12:43 PM, Jan Kara <jack@xxxxxxx> wrote:
> Currently we queue mark into a list of marks for destruction in
> __fsnotify_free_mark() and keep the last mark reference dangling. After the
> worker waits for SRCU period, it drops the last reference to the mark
> which frees it. This scheme has the disadvantage that if we hold
> reference to a mark and drop and reacquire SRCU lock, the mark can get
> freed immediately which is slightly inconvenient and we will need to
> avoid this in the future.
>
> Move to a scheme where queueing of mark into a list of marks for
> destruction happens when the last reference to the mark is dropped. Also
> drop reference to the mark held by group list already when mark is
> removed from that list instead of dropping it only from the destruction
> worker.
>
> Signed-off-by: Jan Kara <jack@xxxxxxx>

Reviewed-by: Amir Goldstein <amir73il@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux